Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variable SNAPRAID_CONF #80

Closed
tehniemer opened this issue Feb 9, 2024 · 8 comments
Closed

Unused variable SNAPRAID_CONF #80

tehniemer opened this issue Feb 9, 2024 · 8 comments

Comments

@tehniemer
Copy link
Contributor

I use OpenMediaVault and am trying out OMV7, in that version the SnapRAID plugin is able to serve muliple arrays so snapraid.conf has a unique name for each array. The variable SNAPRAID_CONF in the config file is able to be set to something different, but it doesn't seem to be referenced at all in the script.

@tehniemer
Copy link
Contributor Author

I'll look into a fix for this and submit a PR, unless you know how to get it fixed quickly.

@auanasgheps
Copy link
Owner

auanasgheps commented Feb 9, 2024

Thanks for reporting, I still haven't upgraded to OMV7 but surely that's in the plans.

@auanasgheps
Copy link
Owner

@tehniemer Is It working fine with OMV7? is there any additional configuration needed?

@tehniemer
Copy link
Contributor Author

It's working as expected.

It would probably be a good idea to add instructions to the config file about changing the default entry for those using OMV7.

@auanasgheps
Copy link
Owner

I will add this information to the README on Github later when I'll try OMV7.

Thanks for letting me know.

@auanasgheps auanasgheps added the documentation Improvements or additions to documentation label Feb 21, 2024
@auanasgheps
Copy link
Owner

Working on updating the path to the default OMV7, which will work for users who have one array.

Adding check and notification in case the config file is not found, will also show the file name.

@auanasgheps auanasgheps added in progress and removed documentation Improvements or additions to documentation labels Mar 8, 2024
@tehniemer
Copy link
Contributor Author

tehniemer commented Mar 8, 2024

I responded to your comment about the name of the .conf file being unpredictable, even with a single array on OMV7 over at that forum. I also think the script should be configured in a way that will allow it to be adaptable to multiple arrays. I'm guessing this could get complicated, but I'm willing to take on the challenge once I get some free time.

Feel free to assign this to me, but maybe a new issue should be opened to address the possibility of multiple arrays.

@auanasgheps
Copy link
Owner

auanasgheps commented Mar 9, 2024

I can close this issue:

  • Dev branch now checks if SnapRAID conf file is not found and alerts the user.
  • Script configuration and docs are updated with OMV7 changes

We'll work on improvements in the other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants