Add prompt dialog when copying clips between projects

[vsverchinsky]

• Add dialog asking user to choose option to either discard trimmed data or copy all contents.
• Dialog should allow "remember my choice"
• There should be an option in preferences that can change remembered user selection
• Add copy progress dialog

Addresses use case issues reported in #3820

[petersampsonaudacity]

Tested this on W10 with @vsverchinsky vVitaly's latest branch build: audacity-win-3.3.0-alpha-20221206+9c91e83-x64-msvc2022
This works fine when you copy a clip from one project to another

a) but can we please also have this dialog and option when copying clips within a project thereby helping to avoid the over-bloated projects that may users have complained about.

b) It is unclear to me whether or not the user's choice for "Selected only" or "Whole" is sticky and retained/remembered if they have ticked the "Don't show me this again" check-box.

[petersampsonaudacity]

UPDATE

The message looks good - but the copy fails to work

If I copy a short selection to another project with this build choosing "Selected only"

a) the length of the selection is OK for the copy

b) no audio is copied - just a selection

The Copy works fine if I choose the "Whole" option

[petersampsonaudacity]

Testing on W10 with @vsverchinsky Vitaly's latest branch: audacity-win-3.2.2-alpha-20221207+12b213c-x64

a) I think the message is improved with the changes - it is slightly misleading for the third button to say Paste smart clip - as with either paste you get a smart clip in the other project, it's just that one has less data than the other - but I think we could probably live with this (I'm finding it hard to think of alternative wordings).
Update: maybe the third button could say Paste full smart clip

b) with the Paste selected audio only selected the audio now does get pasted and it is properly reduced to just the clip

c) BUT if I then check on Remember my choice it fails to do and and has been chaged to Paste smart clip - but now with no dialog displayed to show the reversion
Update: further testing shows that if I select Keep in the dialog than it "remembers" and sets in prefs Discard, so the two settings are transposed it looks like.

d) Examining Track Behaviors prefs shows that the pref has not been changed by checking "on" Remember my choice

e) If I make the change manually in Track Behaviors prefs - then my setting is properly remembered and reused on next use.

f) note that the preference text still just says "copy between projects" rather than "copy and paste between projects" - is this a deliberate design choice which will be retained?

[vsverchinsky]

f) note that the preference text still just says "copy between projects" rather than "copy and paste between projects" - is this a deliberate design choice which will be retained?

No, texts aren't final, option will move to Warnings section

Thanks!

[petersampsonaudacity]

Testing On W10 with @vsverchinsky 's latest branch build: audacity-win-3.2.3-alpha-20221213+7a06e91-x64

This now looks good, much better, with Vitaly's latest branch build

Dialog

I have tested the various combinations and all seem to work well. The dialog looks clear in its intent

Preferences

This is now much clearer in intent to the user, much better

I also tested that the dialog and the prefs interact with each other properly as intended - and indeed they do appear to do so.

[dozzzzer]

Several cosmetic changes are to be made to the dialog:

1. Padding of the dialog should be increased
2. The indent between the radio buttons and their labels should be smaller
3. The indent between the Cancel/Continue buttons should be smaller
4. Change "at anytime" to "at any time" or just "anytime"

[DavidBailes]

Several cosmetic changes are to be made to the dialog:

There are also still a number of accessibility issues with this pull request, which I've previously commented upon in a different thread: #4033 (comment)

[petersampsonaudacity]

Testing on W10- with @vsverchinsky Vitaly's latest branch build for this:

a) the copy properly honor's the user's request to either copy the whole smart clip ot just the selection

b) the displayed data size does not change when toggling between the two copy forms - I would expect the smart clip data size to be much larger than the simple selection size.

c) the "don't ask each time" and the "ask each time" settings work as intended when used fro either the copy dialog or Tracks Behaviors preferences

d) if Ask every time is "on" then the copy dialog properly remembers the users last-used choice for the copy.

e) I note that the default is to set to copy the whole smart clip - is that intentional?

f) At default settings the dialog for Tracks Behaviors preferences is now not quite long enough for the new text:

[petersampsonaudacity]

Testing on @vsverchinsky 's latest branch build: audacity-win-3.3.0-alpha-20230210+429a3c0-x64

I confirm that the Copy dialog no longer has the "X" to cancel the process

BUT consider this use case

1. Generate a five hour chirp to simulate a long recording project
2. select a three minute "song"
3. Ctrl+N to open a new project
4. Ctrl+V to paste the entire smart clip in (the default setting in the dialog)
5. Observe: this takes 2min 24secs on my machine with NO longer any ability to interrupt this

If you make a mistake and intended only to copy in just the selection (which takes less than a second) 0t's like watching paint dry as you wait !

Removing the "X" cancel as a "fix" seems a very kludgy approach and poor UX.

[dozzzzer]

@petersampsonaudacity
without re-writing the existing data models it's hardly possible to address this issue in a better way for now, which doesn't mean we won't do anything about it in the future. I'll create a separate development task for this, too.

[dozzzzer]

Verified