Click Removal setting of 0 for Threshold breaks the Effect

[JohnColket]

Bug description

Setting the Click Removal Threshold to zero (which should be the most sensitive setting), actually does nothing, so this setting should not be allowed.

For some reason it appears that the Click Removal Effect checks to see if zero has been entered, then if so, ignores the request altogether. This is contrary to what is says on the label, "Threshold (lower is more sensitive)". If zero is being special cased, it should have the courtesy to at least generate a Validation error.

This problem was reported by forum user "the wall" here: https://forum.audacityteam.org/viewtopic.php?f=70&t=129047 (3.2.4 on MacOS and confirmed on 3.2.4 on Windows).

Steps to reproduce

1. Generate a 33 minute rhythm track by using the default settings and setting "Number of bars" to 1000.
2. Ctrl+D to duplicate track, then select 2nd track.
3. Effect > Noise Removal and Repair > Click Removal > Threshold > 0 > Apply

Expected behavior

A progress bar and changes made to the audio similar to what happens with a setting of 1.

Actual behavior

Observe Audacity returns immediately (no progress bar) with no change to the audio (verified by invert and mix). It seems that the software is somehow special-casing the value of zero and deliberately not doing anything.

This behavior is incorrect and and is contrary to the documentation: "Threshold (lower is more sensitive)"

Audacity Version

latest stable version (from audacityteam.org/download)

Operating system

Windows, macOS

Additional context

No response

[Ryan-Miller-Audacity]

I confirmed this behavior on Windows in Audacity 3.2.4. Seems lke JohnColket is correct 0 seems to be special cased and does not complete any action. Either an acceptable range should be defined next to the value entry or a warning should show if an unacceptable value is entered.

[Ryan-Miller-Audacity]

Testing this against latest public release (Audacity 3.3.2) this is still reproducible as described there.