Selection Toolbar is broken

[PhoenixClank]

Bug description

The new Selection Toolbar is broken.

Steps to reproduce

1. import some audio
2. select something

Expected behavior

the Selection Toolbar displays the start and end / start and length / length and end / length and center of the selection

Actual behavior

the Selection Toolbar displays nothing at all

Audacity Version

stable version (from a Linux repository)

Operating system

Linux

Additional context

OS: Arch Linux
Audacity version: 1:3.3.0-1
screenshot:

(the entire third track is selected)

[koshikas]

although reported as a bug of 3.3.0 this is supposedly introduced with 3.3.1

info;
System:
Kernel: 5.15.109-1-MANJARO arch: x86_64 bits: 64 compiler: gcc v: 12.2.1
Desktop: KDE Plasma v: 5.27.4 tk: Qt v: 5.15.9 wm: kwin_x11 vt: 1 dm: SDDM
Distro: Manjaro Linux base: Arch Linux

sometimes the selection panel covers the entire work area on top of the wave area of the loaded file. it is intermittent though, sometimes functioning as expected. when the bug occurs, the selection panel cover entire work area, even with no file loaded.
i did clear setting with Tools -> Reset Configuration

Audacity_dbgrpt-23593-20230430T100847.zip

[petersampsonaudacity]

Works fine for me with 3.3.1 on W10

[crsib]

It seems that this issue only affects the pacman provided version on Arch Linux. I've built a "full system" version of Audacity on Arch and I cannot reproduce this issue. Probably @dvzrv can help.

[dvzrv]

I've built a "full system" version of Audacity on Arch

What do you mean by that?

The PKGBUILD used to build the package for Arch Linux can be found here: https://github.com/archlinux/svntogit-community/blob/0a1d3d663336f9e69d557d08933f8c5a10d5eebc/trunk/PKGBUILD

As this issue and also #4639 have surfaced after the release of 3.3.0, my assumption is, that it's some kind of regression.
wxwidgets is currently at 3.2.2.1 and has not seen any updates since early February.
Would there be any other component you suspect could be causing this?

[crsib]

What do you mean by that?

I've built a version with Conan disabled and I am unable to reproduce the problem. It only reproduces when Audacity is installed using pacman.

[dvzrv]

I've built a version with Conan disabled and I am unable to reproduce the problem.

Have you done that in a clean chroot using the build flags mentioned in the above link?
How did you build audacity specifically?

[crsib]

mentioned in the above link

Most of the flags there reflect the default behavior.

clean chroot

No

[dvzrv]

Most of the flags there reflect the default behavior.

Maybe. However, there is e.g. -D CMAKE_BUILD_TYPE=None and we have our own CFLAGS, CXXFLAGS and LDFLAGS.

When not building in a clean chroot it is unfortunately unclear what gets pulled in by the build (you may have custom versions of toolkits or libraries installed, etc.).

[crsib]

I have a fresh installation of Arch :-)

I'm running makepkg now, assuming it does chroot. I'm not sure if it will bring any use, inability to locally reproduce the issue is a big problem.

[dvzrv]

I'm running makepkg now, assuming it does chroot.

It builds against your current system. If you install devtools you can use extra-x86_64-build to build in a clean chroot.

Meanwhile I have rebuilt to see whether the I can remove the RPATH fixes (which seems fixed). Unfortunately my audacity is not really usable:

I wonder whether some of the issues come from theming or something similar.

[dvzrv]

Experimentally I have tried -D CMAKE_BUILD_TYPE=Release, switched to using the dark theme and now I am unable to import audio tracks:

There are actually two tracks in that session, but both do not display their waveform (but I can play them):

After closing that session and opening audacity anew, it looks different:

An import still does not show the waveform of the audio. Also tried forcing audacity into XWayland (by starting it with GDK_BACKEND=x11 DISPLAY=:0 audacity).

[dvzrv]

Doing the build as shown in the previously mentioned PKGBUILD I see a lot of -DEXPERIMENTAL_* definitions fly by. I don't really know whether that is supposed to be like that.
Either way, I am at least able to open a file and see a waveform. However, none of the time widgets (e.g. selection etc.) show anything. Same for the "Generate-> X" popups (see #3237).

For posterity, here some current build logs:
audacity-1:3.3.0-1-x86_64-build.log
audacity-1:3.3.1-1-x86_64-build.log (currently in the repos)
audacity-1:3.3.1-2-x86_64-build.log (rebuilt without the RPATH fix - should not have any consequence for the widget issues we are seeing in this ticket)

[crsib]

I can only reproduce it using the extra-x86_64-build, which makes it extremely hard to fix

[crsib]

Most likely one of the tables in lib-numeric-formats is not populated (NumericConverterRegistry::Registry()). This is odd, as Audacity utilizes multiple registries and the seem to work just fine.

[dvzrv]

I can only reproduce it using the extra-x86_64-build, which makes it extremely hard to fix

So I guess your assumption is, that it's due to one of the CFLAGS/CXXFLAGS/LDFLAGS in use?
If you have a specific one in mind (in any of the three sets) we could test without it.

[crsib]

I'm looking through them now

[dvzrv]

Ah, before I forget: LTO is on by default as well for quite some time now.

[dvzrv]

Ah, before I forget: LTO is on by default as well for quite some time now.

Aaaaaaaand bingo:

I'll have to disable LTO for now I guess :)

[crsib]

Hmm, I'm not quite sure how LTO can affect this. I'd best figure it out anyway

[dvzrv]

Hmm, I'm not quite sure how LTO can affect this. I'd best figure it out anyway

Good luck and keep me posted! :)

[crsib]

Good luck and keep me posted! :)

I will! Thank you for your help, David!

[crsib]

Seems to be a case of "static initialization order ‘fiasco’". Interesting that it worked fine on 3 compilers except for the LTO case.

[PhoenixClank]

I just upgraded my system and this is fixed, thanks! But I don't know if I should close this issue because the linked PR is still open.

[Ryan-Miller-Audacity]

Confirmed fixed in my Linux VMs via PR #4464. Selection Toolbar now properly displays values. Sanity checked Windows and MacOS and confirmed no adverse behaviors.