Cleanup plugin and module managers #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paul-Licameli
force-pushed
the
Cleanup-Plugin-and-Module-Managers
branch
from
060538c
to
9339028
Compare
gera-gas
approved these changes
Jun 30, 2021
... just enough for the PluginRegistrationDialog to do its work
... so that PluginManager can avoid using GUI
Paul-Licameli
force-pushed
the
Cleanup-Plugin-and-Module-Managers
branch
from
9339028
to
d5a22df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to internals of #992
Make the PluginManager and ModuleManager classes more understandable and maintainable.
break the cyclic dependency between them
separate the GUI to manipulate the PluginManager (the PluginRegistrationDialog) into other files
simplify memory management
simplify iterations over plug-ins
I signed CLA
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"