Modernization #2343
Merged
Modernization #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
vsverchinsky
previously approved these changes
Dec 30, 2021
|
I will fix the build, and may use duration_cast as suggested, and will re-request review. |
Paul-Licameli
force-pushed
the
modernization
branch
7 times, most recently
from
6ec5881
to
5b9e78b
Compare
As I promised. Please review the last three, new commits. Nothing has changed in the earlier commits except for rebasing and supplying needed include directives. |
Paul-Licameli
force-pushed
the
modernization
branch
from
f684e70
to
d162f17
Compare
Paul-Licameli
force-pushed
the
modernization
branch
from
d162f17
to
40af587
Compare
Paul-Licameli
dismissed
vsverchinsky’s stale review
Requesting review of three newest commits added since last review
vsverchinsky
approved these changes
Jan 10, 2022
Paul-Licameli
force-pushed
the
modernization
branch
from
40af587
to
1e4a589
Compare
... where they must mix with un-typed numbers, including calls to wxTimer methods. Change the name of one so it doesn't mention the period. Do not use duration_cast, but use other conversions that check for non-lossiness at compile time.
Paul-Licameli
force-pushed
the
modernization
branch
from
1e4a589
to
c814e58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use more C++14 and C++17 library types
Recommended: