Disallow adding a destructive, or realtime, effect which has been deleted since application start up. #3801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsverchinsky
requested changes
Oct 14, 2022
ksoze95
force-pushed
the
use_deleted_vst_plugin_before_rescan_crash
branch
from
d90a5b4
to
7e6dfad
Compare
ksoze95
force-pushed
the
use_deleted_vst_plugin_before_rescan_crash
branch
from
7e6dfad
to
a8777ea
Compare
vsverchinsky
approved these changes
Oct 17, 2022
src/RealtimeEffectPanel.cpp
Outdated
| return; | ||
|
|
||
| if(!PluginManager::IsPluginAvailable(*plug)) { | ||
| wxMessageBox(_("This plugin could not be loaded.\nIt may have been deleted."), _("Plugin Error")); |
There was a problem hiding this comment.
Use ::AudacityMessageBox
There was a problem hiding this comment.
Replaced wxMessageBox with BasicUI::ShowMessageBox as suggested below.
Paul-Licameli
suggested changes
Oct 17, 2022
src/effects/EffectUI.cpp
Outdated
| @@ -1231,6 +1231,12 @@ DialogFactoryResults EffectUI::DialogFactory(wxWindow &parent, | |||
| if (!plug) | |||
| return false; | |||
|
|
|||
| if (!PluginManager::IsPluginAvailable(*plug)) | |||
| { | |||
| wxMessageBox(_("This plugin could not be loaded.\nIt may have been deleted."), _("Plugin Error")); | |||
There was a problem hiding this comment.
Use ::AudacityMessageBox
There was a problem hiding this comment.
Or better, use BasicUI::ShowMessageBox in both places.
ksoze95
force-pushed
the
use_deleted_vst_plugin_before_rescan_crash
branch
from
a8777ea
to
7d8ba28
Compare
ksoze95
force-pushed
the
use_deleted_vst_plugin_before_rescan_crash
branch
from
7d8ba28
to
13bd133
Compare
ksoze95
force-pushed
the
use_deleted_vst_plugin_before_rescan_crash
branch
from
13bd133
to
ac75f13
Compare
LWinterberg
reviewed
Oct 27, 2022
src/menus/FileMenus.cpp
Outdated
Comment on lines
219
to
222
| BasicUI::ShowMessageBox( | ||
| XO("This project contains some plugins that cannot be found on the system."), | ||
| BasicUI::MessageBoxOptions() | ||
| .Caption(XO("Project Error"))); |
There was a problem hiding this comment.
Let's do
Window title: Missing Plugins
This project contains some realtime effect plugins that cannot be found on this system.
The project may sound different than intended. Learn more
[OK]
with the "learn more" having an accessible link to https://audacityteam.org/errors#missing-plugins
ksoze95
force-pushed
the
use_deleted_vst_plugin_before_rescan_crash
branch
2 times, most recently
from
bfd6cbf
to
5300bae
Compare
LWinterberg
approved these changes
Nov 15, 2022
ksoze95
force-pushed
the
use_deleted_vst_plugin_before_rescan_crash
branch
from
5300bae
to
34f95a5
Compare
Paul-Licameli
approved these changes
Dec 9, 2022
ksoze95
force-pushed
the
use_deleted_vst_plugin_before_rescan_crash
branch
from
34f95a5
to
1cafa45
Compare
added 2 commits
December 19, 2022 12:31
... been deleted to stop a protential crash.
ksoze95
force-pushed
the
use_deleted_vst_plugin_before_rescan_crash
branch
from
1cafa45
to
bdfd848
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3719 #3817
(short description of the changes and the motivation to make the changes)
Recommended: