FFmpeg 6 support #4419
FFmpeg 6 support #4419
Conversation
| @@ -0,0 +1,37 @@ | |||
| extern "C" | |||
There was a problem hiding this comment.
No top-of file banner, which analogous files for version 55 do have, but other versions don't have.
| impl/avcodec/60/AVCodecIDLookup.cpp | ||
| impl/avcodec/60/AVCodecImpl.cpp | ||
| impl/avformat/60/AVFormatImpl.cpp | ||
| impl/avutil/58/AVUtilImpl.cpp |
There was a problem hiding this comment.
I see a mix of "58" and "60" here which I assume is intended
There was a problem hiding this comment.
But maybe this will surprise a future reader and a bit of comment might help
| @@ -0,0 +1,37 @@ | |||
| extern "C" | |||
| { | |||
| #include "../../avutil/58/avconfig.h" | |||
There was a problem hiding this comment.
60 using 58 again, comment ?
There was a problem hiding this comment.
This files are literally copied, none of the original files has a comment about different versions between avutil and the rest of the libraries.
The difference between versions is due to the difference inside the FFmpeg itself. I wonder why it is, but I don't quite know :-)
| @@ -0,0 +1,46 @@ | |||
| extern "C" | |||
| { | |||
| #include "../../avutil/58/avconfig.h" | |||
|
|
||
| extern "C" | ||
| { | ||
| #include "../../avutil/58/avconfig.h" |
There was a problem hiding this comment.
Or maybe not? ... maybe this difference of number is just frequent in all the other versions too. I'm comparing with 55 for instance.
Resolves: #4381
(short description of the changes and the motivation to make the changes)
Recommended: