Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the audio.com upload flow #4743

Merged
merged 3 commits into from Jun 7, 2023
Merged

Fixes the audio.com upload flow #4743

merged 3 commits into from Jun 7, 2023

Conversation

crsib
Copy link
Contributor

@crsib crsib commented May 29, 2023 •
edited

  1. Track Title field is added
  2. After the upload is completed URL is opened in the browser immediately
  • I signed CLA
  • The title of the pull request describes an issue it addresses
  • If changes are extensive, then there is a sequence of easily reviewable commits
  • Each commit's message describes its purpose and effects
  • There are no behavior changes unnecessary for the stated purpose of the PR

Recommended:

  • Each commit compiles and runs on my machine without known undesirable changes of behavior

@crsib crsib added this to the Audacity 3.4 milestone May 29, 2023
@crsib crsib requested a review from vsverchinsky May 29, 2023 14:10
@crsib crsib self-assigned this May 29, 2023
@dozzzzer
Copy link
Contributor

Tested. A new issue was found: #4747

@crsib crsib changed the base branch from master to release-3.3.3 June 7, 2023 08:08
vsverchinsky
vsverchinsky approved these changes Jun 7, 2023
View reviewed changes
libraries/lib-cloud-audiocom/UploadService.cpp
@@ -579,7 +586,7 @@ UploadOperationHandle UploadService::Upload(
mServiceConfig, fileName, projectName, isPublic,
std::move(completedCallback), std::move(progressCallback));

mOAuthService.ValidateAuth([operation](std::string_view authToken)
mOAuthService.ValidateAuth([operation, this](std::string_view authToken)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't used

@Ryan-Miller-Audacity Ryan-Miller-Audacity self-assigned this Jun 7, 2023
@Ryan-Miller-Audacity
Copy link

Tested and confirmed the following to the Audio.com upload flow: track title field is added and required for upload, track title field is focused upon opening the dialog, Anonymous uploads are not allowed, linking audio.com account works as expected (auto and manual), and audio.com link is opened immediately upon upload.

Tested the above in Windows, MacOS, and Linux.

@crsib crsib merged commit 3f3551f into audacity:release-3.3.3 Jun 7, 2023
@crsib crsib deleted the new_upload_flow branch June 7, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsverchinsky vsverchinsky vsverchinsky approved these changes

Assignees

@crsib crsib

@Ryan-Miller-Audacity Ryan-Miller-Audacity

Labels
audio sharing
Projects
Main board
Status: Done
Milestone
Audacity 3.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crsib @dozzzzer @Ryan-Miller-Audacity @vsverchinsky