Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translations #558

Closed
wants to merge 3 commits into from
Closed

Conversation

mikhailnov
Copy link
Contributor

Some menu entries were not translated in Russian, some were not transalted in all languages. Fixed them.
Screenshot bellow shows untranslated strings, now they are translated.
DeepinScreenshot_выберите-область_20200531044140

"Filter Curve EQ" was previosuly splitted into two different filters,
but "Filter Curve" was not transalted in the "Filter" menu.

To preserve existing translations, I ran
sed -i -e 's,Filter Curve EQ,Filter Curve,g' *.po

Russian translation is updated to translate the name of this effect better.
@mikhailnov mikhailnov changed the title Fix transaltions Fix translations May 31, 2020
vt-alt pushed a commit to altlinux/specs that referenced this pull request May 31, 2020
- Version v2.4.1 + git master from 2020-05-30, commit d6f8410d5
  Git has fixes for newest wxWidgets 3.1.3 and some other important bug fixes
- Ensuring that libmp3lame and ffmpeg are linked but not dlopened
- Ensuring that package version and the one in the "About" dialog are the same
- Fixed Russian translation
  PRed to upstream: audacity/audacity#558
@JamesCrook
Copy link
Contributor

Thanks.

But
(a) Please only change po files for the languages you offer to translate (even if via script).
(b) Please do updated po files for your own language (Russian) via the translator's email list, where conflicts between different translators/translations can be resolved, and general issues with translatability that affect all translations can be discussed with all translators.

I generally prefer to receive updated .po files via that list, rather than as pull requests.

Pull request rejected.

@JamesCrook JamesCrook closed this May 31, 2020
@mikhailnov
Copy link
Contributor Author

a) as you see, I changed a string in the source code, so it was necessary to update all pot and po files, how do you suggest to handle this?
b) ok, I will write there, but I would suggest that an updated po file is pull requested after it is accepted in the list

@JamesCrook
Copy link
Contributor

a) Just request the change in the source (pull request is fine). If it is only a string change, maybe mention it is a 'Wording change'. The script will be run at the start of translation freeze, and translators will then be asked for updated translations.
b) That's not how we do it. After end of translation freeze stage, and before making rcs, I diff the new .po against the old, and can sometimes pick up mistakes even though I don't speak the languages. The order of strings is unchanged which makes the diffing actually useful.

@mikhailnov
Copy link
Contributor Author

Thanks for explaining. So, I should first request a change of the string without changing anything in locale/. Send a PR with that change. Then wait for long and only then have a chance to suggest my translation of the new wording?

@JamesCrook
Copy link
Contributor

Thanks for explaining. So, I should first request a change of the string without changing anything in locale/. Send a PR with that change.

Correct.

You don't need to suggest the new wording. The existing translator will do it.

If you want to get involved in translating, then you really need to be subscribed to the translators list and work with existing translators there.

vt-alt pushed a commit to altlinux/specs that referenced this pull request Nov 19, 2021
- Version 3.1.2 (Closes: 40174, 38790, 38662, 41340)
- Do load plugins from /usr/lib/ladspa in addition to /usr/lib64/ladspa
  (this upstream behaviour was incorrectly changed by sed)
- XXX Upstream removed linkage with libffmpeg, so we do not have propper ABI tracking now
  and depend from libavocodec.so.58 manually
  (audacity/audacity#2161)
- Build against system libopus, libportaudio and libmidi (as in upstream spec for Fedora)
- Dropped setting of correct version in the "About" dialog, upstream code changed,
  it is set correctly now by cmake variables like AUDACITY_VERSION
- Dropped no more needed patches:
  + ALT-Remove-warning-about-alpha-version.patch - upstream code changed, using
    "-DAUDACITY_BUILD_LEVEL=2" now
  + 0001-HACK-off-bundled-libmp3lame.patch - libmp3lame is not bundled any more,
    a chack that system one is linked is kept in %check
  + 0001-update-PO-files-by-update_po_files.sh.patch,
    0002-Fix-fuzzies-in-Russian-transaltion.patch,
    0003-Fix-translation-of-Filter-Curve.patch - dropped in the new version,
    upstream has a special workflow of updating translations
    (see audacity/audacity#558)
- Renamed and rediffed other patches, make all of them git am-able
- Hacked to force GTK+3.0 at build time
- Removed hack with -latomic on MIPS, upstream CMakeLists.txt adds it itself
- Hacked for liblame-devel missing pkgconfig file
  (reported https://bugzilla.altlinux.org/show_bug.cgi?id=40342)
- Explicitly disabled networking (it is disabled by default, make sure that
  we do not send crash reports to Audacity servers, they will not be able
  to read them due to debuginfo available separately and because it is not their build)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants