Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use noinst_SCRIPTS for toplevel audacity script. #75

Closed
wants to merge 1 commit into from

Conversation

0-wiz-0
Copy link

@0-wiz-0 0-wiz-0 commented Sep 18, 2015

When using libtool, this file is a copy of a shell script
and will be installed instead of the real executable.

When using libtool, this file is a copy of a shell script
and will be installed instead of the real executable instead.
@ferdnyc
Copy link

ferdnyc commented Jan 15, 2017

bin_SCRIPTS was changed to bin_PROGRAMS in commit 8d82270 (hence the conflict) — that seems correct, as the file in question was never a script. It's a copy of the compiled executable:

audacity$(EXEEXT): src/audacity$(EXEEXT)
	rm -f audacity$(EXEEXT)
	cp src/audacity$(EXEEXT) audacity$(EXEEXT)
	[ -e plug-ins ] || ln -s $(srcdir)/plug-ins
	[ -e nyquist ] || ln -s $(srcdir)/nyquist
	[ -e locale ] || ln -s po locale

So, with that executable correctly categorized as bin_PROGRAMS, I believe this can be closed as superseded by that change, no? I don't see that we'd want the executable to be noinst.

@0-wiz-0
Copy link
Author

0-wiz-0 commented Jan 15, 2017

My original point is still valid.
When building on Unix with libtool, src/audacity$(EXEEXT) is a shell wrapper that sets the library search path before calling the real executable. libtool --install ... then creates the actual binary.
The target in the main Makefile.am runs too early and copies the shell wrapper, which points to the build path.

@JamesCrook
Copy link
Contributor

Sorry, this has sat in the queue too long and is now being closed as we couldn't decide on progressing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants