Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show syntax error location when running into jinja2.exceptions.TemplateS... #53

Merged

Conversation

bitmensch
Copy link
Contributor

...yntaxError

This fixes #50.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.85%) when pulling 5375172 on benjixx:verbose-template-syntax-error into cf1fb09 on audreyr:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.66%) when pulling 3111b67 on benjixx:verbose-template-syntax-error into cf1fb09 on audreyr:master.

@thedrow
Copy link
Contributor

thedrow commented Aug 28, 2013

Note that this pull request closes #50.
Why does the coverage decrease?

@audreyfeldroy
Copy link
Member

I think the "decrease" is a bug in @coveralls, but I'm not sure. Anyone know?

@thedrow
Copy link
Contributor

thedrow commented Aug 28, 2013

@audreyr When you run it locally does the coverage decrease?

@bitmensch
Copy link
Contributor Author

The strange thing is that I received a mail from coveralls where it says:

Coverage remained the same

@audreyfeldroy audreyfeldroy merged commit 3111b67 into cookiecutter:master Aug 31, 2013
@audreyfeldroy
Copy link
Member

Merged this into master, it's great! Will do a PyPI release very soon. Thank you!

Honestly I haven't yet figured out how to generate local combined coverage.py reports that show 2.6+2.7+3.3 coverage, so I don't actually know the total coverage other than what Coveralls reports. But I will work on this when I get a chance.

JosephGasiorekUSDS pushed a commit to JosephGasiorekUSDS/cookiecutter that referenced this pull request Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jinja breaks on syntax error without reporting where the error occured
4 participants