Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-pre-gyp support #40

Open
audreyt opened this issue Oct 17, 2014 · 14 comments
Open

node-pre-gyp support #40

audreyt opened this issue Oct 17, 2014 · 14 comments

Comments

@audreyt
Copy link
Owner

audreyt commented Oct 17, 2014

@springmeyer mentioned it's a viable option now, over at sindresorhus/awesome-nodejs#117 (comment) — URLs to relevant documentations & pullreqs welcome!

@springmeyer
Copy link
Collaborator

@audreyt
Copy link
Owner Author

audreyt commented Oct 17, 2014

🌈 👍

@springmeyer
Copy link
Collaborator

Okay, first pass of the port is done:

Next steps:

  • What platforms do you want to support with binaries? Linux, Windows, and OS X?
  • Do you want to host the binaries on S3 or do you wish to provide an alternative host?

@springmeyer
Copy link
Collaborator

I'll add:

@audreyt
Copy link
Owner Author

audreyt commented Oct 18, 2014

@springmeyer How large are the Linux, Windows and OS X binaries? If they are reasonably small (<1MB each) I'd like to host them in audreyt.github.io/node-webworker-threads/ — that is, in the gh-pages branch of this repo — if that sounds reasonable to you.

BTW you're a committer now! Please merge when you feel it's ready.

@springmeyer
Copy link
Collaborator

@audreyt - the OS X binary is 93 KB so hosting them in the gh-pages branch seems reasonable. Because the node-pre-gyp publish command only supports s3 hosts then publishing to the gh-pages branch will need some alternative automation.

@audreyt
Copy link
Owner Author

audreyt commented Oct 20, 2014

OK! Good to know, looking forward to the commits 👍

@thorlarholm
Copy link

This would be a very welcome addition.

How ready is this and what steps remain before webworker-threads has node-pre-gyp support?

@springmeyer
Copy link
Collaborator

then publishing to the gh-pages branch will need some alternative automation.

@thorlarholm ^^ this is the next bit that needs work. Because @audreyt wishes to host on github rather than s3 someone needs to write a bit of code to auto-publish binaries. This should not be hard - but would take a bit of time. I sketched out some basics over at mapbox/node-pre-gyp#134 (comment) if you are interested in tackling this.

@thorlarholm
Copy link

Thanks @springmeyer I forked your changes and started work on publishing to gh-pages.

@springmeyer
Copy link
Collaborator

Great @thorlarholm

@audreyt
Copy link
Owner Author

audreyt commented Jan 13, 2015

@thorlarholm awesome, much kudos! 🌈

@thorlarholm
Copy link

Don't congratulate me too much, I had to ditch my fork due to work obligations.

This is still an open issue.

@Drakulix
Copy link

What about using this instead to publish the prebuild modules to Githubs Releases?
https://www.npmjs.com/package/node-pre-gyp-github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants