-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node-pre-gyp support #40
Comments
started porting in mapbox/node-webworker-threads@audreyt:master...master |
🌈 👍 |
Okay, first pass of the port is done:
Next steps:
|
I'll add:
|
@springmeyer How large are the Linux, Windows and OS X binaries? If they are reasonably small (<1MB each) I'd like to host them in audreyt.github.io/node-webworker-threads/ — that is, in the BTW you're a committer now! Please merge when you feel it's ready. |
@audreyt - the OS X binary is 93 KB so hosting them in the gh-pages branch seems reasonable. Because the |
OK! Good to know, looking forward to the commits 👍 |
This would be a very welcome addition. How ready is this and what steps remain before webworker-threads has node-pre-gyp support? |
@thorlarholm ^^ this is the next bit that needs work. Because @audreyt wishes to host on github rather than s3 someone needs to write a bit of code to auto-publish binaries. This should not be hard - but would take a bit of time. I sketched out some basics over at mapbox/node-pre-gyp#134 (comment) if you are interested in tackling this. |
Thanks @springmeyer I forked your changes and started work on publishing to gh-pages. |
Great @thorlarholm |
@thorlarholm awesome, much kudos! 🌈 |
Don't congratulate me too much, I had to ditch my fork due to work obligations. This is still an open issue. |
What about using this instead to publish the prebuild modules to Githubs Releases? |
@springmeyer mentioned it's a viable option now, over at sindresorhus/awesome-nodejs#117 (comment) — URLs to relevant documentations & pullreqs welcome!
The text was updated successfully, but these errors were encountered: