Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating Dock Blur #25

Closed
Kyanoxia opened this issue Mar 30, 2021 · 6 comments
Closed

Floating Dock Blur #25

Kyanoxia opened this issue Mar 30, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request external Something that comes from an external source (such as Gnome Shell)

Comments

@Kyanoxia
Copy link

As of now, this blur takes the shape of a normal dock, and adapts itself to dash to dock's settings. There is an extension that I particularly love to use, called Floating Dock. However Blur My Shell doesn't like it. I would appreciate it if you could add floating dock mode, where you can add rounded corners, and allow it to float off the bottom of the screen.

@aunetx
Copy link
Owner

aunetx commented Apr 18, 2021

I'm sorry, rounding corners is something that I really can't do, especially with the time I can spend now... Gnome has not implemented a way to give a particular shape to the blur, so the best I can do is rectangular!

Allowing it to float off the bottom of the screen could be doable, but what is it doing now? Normally, it should have the exact same height as the dock, so if this is not the case, it means that I would need to change a bunch of things so it stays compatible with vanilla dash to dock...

@aunetx aunetx self-assigned this Apr 18, 2021
@aunetx aunetx added enhancement New feature or request external Something that comes from an external source (such as Gnome Shell) labels Apr 18, 2021
@aunetx
Copy link
Owner

aunetx commented Apr 21, 2021

Could you test with latest commits on the gnome-40 branch? As dash-to-dock is now floating, it may works now

@CorvetteCole
Copy link
Collaborator

I have a few ideas for how to shape blur I was experimenting with for #39 . It might be a possibility, just wanted to put that out there

@CorvetteCole
Copy link
Collaborator

rounded corners issue can be found in #8 by the way

@aunetx
Copy link
Owner

aunetx commented Jul 28, 2021

I'm closing this, as I only plan to add support for very used extensions (Dash to Dock, Dash to Panel, ...) or official gnome extensions (such as Window List), because the work would be too much for me else...

You can contact the official maintained of Floating Dock if needed, it is very easy to add blur from within its extension (but pretty hard from another extension, such as Blur my Shell). He--or you-- can contact me if you need help implementing blur in this extension, although I'm pretty sure there will be no way to get rounded blur with the current gnome implementation.

@aunetx aunetx closed this as completed Jul 28, 2021
@matfantinel
Copy link

I wanna add that I was able to mimic rounded corners with Floating Dock by doing the following:

  • In Blur my Shell settings, set Brightness to max, and Sigma to a low value (I kept it at 15)
  • In Floating Dock settings, I set Opacity to 60%. This way it mimics a lower blur brightness.

Matched with a fitting wallpaper, it looks like the dock blur is rounded:

image

Keep in mind that the 100% brightness might make the panel/overview blur look bad. In my case, I only enable blur for the dock, so it looks pretty good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external Something that comes from an external source (such as Gnome Shell)
Projects
None yet
Development

No branches or pull requests

4 participants