-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-write Aura as a single-file library #55
Comments
Initial work for this checked in under addyosmani/backbone-aura@4a233fc. I'll continue working in branch on this. Happy for anyone else to pitch it. Current status is that the demo app renders but we're getting a bunch of type errors. I assume this is related to some breakage occurring in how components are now being pulled in. |
I'm tempted for us to drop the idea of Aura being a single library. On the contrary I feel like the developers using us are already using RequireJS, like the idea of modularity and pulling in our dependencies isn't a pain point. We could be opinionated in that way and instead focus on providing a great architecture, better support for the feature RequireJS does expose under the sheets (or plugins which help with that). @sindresorhus @gersongoulart what do you think? |
I absolutely agree. There's a good reason jQuery is going the opposite way single-file -> modular. |
Glad to hear you agree :) |
I've tackled a similar tricky plumbing for a library that I'm currently working on. If you don't mind, I can take a stab at this for 1.0. The way I've done it is, the library in question works identically minified, or as exploded sources, just as yet another library sitting inside the The Aura project can be restructured as follows:
To be honest, I was mildly confused as to what file was for what, and what the boundaries of Aura were, when I first started looking at this project. I think a folder organization like the above could help clear things up. All the sample application assets would clearly be enclosed inside the The aim of the redundant I don't have an answer for where the Backbone extensions should reside. Are they a part of Aura? Should they come with the sample todos application? Or should extensions lie inside an entirely different |
Thanks for kickstarting off this discussion again. I think there are a few parts to this.
I have concerns about us trying to tackle this for 1.0, even though I would love that. I remember how long it took me to get the POC put together in a way that many of the parts actually worked sans RequireJS and I'd worry that we might end up spending a lot of time working on this that could be spent landing other 1.0 features, docs or tests. For now, would we be down for the directory structure changes once incoming PRs for the rest of our milestone land? :) |
@addyosmani I agree. A change to both the project structure and build process could be very upsetting during the 1.0 crunch. I could still work on a PoC when I find the time... Off-topic question: Me having direct write access to this repo -- does it mean I can take the liberty to directly make changes for minor, low risk stuff like typos? Or should I always stick to the PR process? |
Yes! Any minor changes can be made directly. Please feel free to. |
@addyosmani I guess we can close this one now ? |
Yes! |
Covers Core, Sandbox and Permissions. There will be some tricky plumbing required to get this working but it should be possible.
The text was updated successfully, but these errors were encountered: