-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HHVM back as a build target #72
Comments
Sorry it is still not yet fixed at travis https://travis-ci.org/harikt/Aura.Sql/jobs/23688419 . Probably once they update to latest we can add. |
Okay fair enough, thanks for trying! |
We will open once travis is with the new version. And you are welcome. Next time you can open the PR and we will see whether we can merge or not ;) . |
Just noticed that Travis is running against 3.1 now. Maybe worthwhile to start testing against HHVM again? |
@iansltx still failing https://travis-ci.org/auraphp/Aura.Sql/jobs/23688453 |
Looks like the issue is here: https://github.com/facebook/hhvm/blob/master/hphp/runtime/ext/ext_pdo.cpp#L755 and Docctrine worked around it here: I may have a workaround for this though... |
@iansltx come with a fix, we will merge 👍 . Thank you. |
50/50 that this will be labelled as wontfix, but here goes nothing: |
It looks like the issue that previously blocked its usage has been fixed:
facebook/hhvm#1560
There might be other blockers, but it's worth trying again IMO.
The text was updated successfully, but these errors were encountered: