Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HHVM back as a build target #72

Closed
jklein opened this issue Apr 24, 2014 · 8 comments
Closed

Add HHVM back as a build target #72

jklein opened this issue Apr 24, 2014 · 8 comments

Comments

@jklein
Copy link
Contributor

jklein commented Apr 24, 2014

It looks like the issue that previously blocked its usage has been fixed:

facebook/hhvm#1560

There might be other blockers, but it's worth trying again IMO.

@harikt
Copy link
Member

harikt commented Apr 24, 2014

Sorry it is still not yet fixed at travis https://travis-ci.org/harikt/Aura.Sql/jobs/23688419 . Probably once they update to latest we can add.

@jklein
Copy link
Contributor Author

jklein commented Apr 24, 2014

Okay fair enough, thanks for trying!

@harikt
Copy link
Member

harikt commented Apr 24, 2014

We will open once travis is with the new version. And you are welcome. Next time you can open the PR and we will see whether we can merge or not ;) .

@harikt harikt closed this as completed Apr 24, 2014
@iansltx
Copy link
Contributor

iansltx commented Jun 26, 2014

Just noticed that Travis is running against 3.1 now. Maybe worthwhile to start testing against HHVM again?

@harikt
Copy link
Member

harikt commented Jun 26, 2014

@iansltx
Copy link
Contributor

iansltx commented Jun 26, 2014

Looks like the issue is here:

https://github.com/facebook/hhvm/blob/master/hphp/runtime/ext/ext_pdo.cpp#L755

and Docctrine worked around it here:

doctrine/dbal#495

I may have a workaround for this though...

@harikt
Copy link
Member

harikt commented Jun 26, 2014

@iansltx come with a fix, we will merge 👍 .

Thank you.

@iansltx
Copy link
Contributor

iansltx commented Jun 26, 2014

50/50 that this will be labelled as wontfix, but here goes nothing:

facebook/hhvm#3041

pmjones pushed a commit that referenced this issue Jun 26, 2014
Add HHVM compatibility, fixes #72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants