Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Add Search delay #22

Closed
lenn123 opened this issue Apr 5, 2017 · 8 comments
Closed

Request: Add Search delay #22

lenn123 opened this issue Apr 5, 2017 · 8 comments

Comments

@lenn123
Copy link

lenn123 commented Apr 5, 2017

The widget is highly appreciated!

It would be great if a search delay (in milliseconds) can be added before the search is executed.

@lindski
Copy link
Contributor

lindski commented Apr 24, 2017

Thanks!

Before processing the results, the widget checks to ensure that the search term hasn't changed. If it has changed then it doesn't process the results (it expects a new result set matching the new term).

Are you seeing results appear that do not match the search term?

@lenn123
Copy link
Author

lenn123 commented Apr 25, 2017

No, we are using a microflow to fill in our search results which is calling a webservice. In order to prevent the webservice call in it self it would be nice to limit this based on a preset delay. This delay is basically a timeout that calls the _findMatches functions, kind of like in the Onchangeinputbox https://github.com/mendix/OnchangeInputbox. Reasons to limit the webservice calls are cost efficiency (each call costs money) but also resource efficiency as webservice calls are relatively costly server operations.

@lindski
Copy link
Contributor

lindski commented Apr 25, 2017

Ok, I understand the problem. Will have a look and see what we can do.

iain

@lindski
Copy link
Contributor

lindski commented Apr 26, 2017

Hi,

I've added a new parameter in commit 1edd02b called 'Search Delay' (under the 'Search' tab) that allows you to define a delay in milliseconds. The widget now waits for the user to stop typing for this configured time period before the search is executed.

An updated widget is available in the test project... can you check to see if this meets your expectations and then I will create a release and get it published to the appstore.

Cheers

iain

@lenn123
Copy link
Author

lenn123 commented Apr 26, 2017

Hi,

I just tested the new version of the widget. This is exactly as I would expect it to work! Thank you very much for the quick change. It is highly appreciated!

@lindski
Copy link
Contributor

lindski commented Apr 26, 2017

Great, have created a 3.1.1 release... will close this issue when its available on the app store

@lindski
Copy link
Contributor

lindski commented May 5, 2017

Version 3.1.1 now available on the app store

@lindski lindski closed this as completed May 5, 2017
@lenn123
Copy link
Author

lenn123 commented May 5, 2017

Thanks again!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants