feat(templating): allow deactivate when activating #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1729 +/- ##
==========================================
+ Coverage 87.99% 88.01% +0.02%
==========================================
Files 242 242
Lines 22532 22555 +23
Branches 5156 5163 +7
==========================================
+ Hits 19826 19852 +26
+ Misses 2706 2703 -3
... and 2 files with indirect coverage changes π£ Weβre building smart automated test selection to slash your CI/CD build times. Learn more |
|
For such a large change in a core component like the controller, we need some supporting tests. |
AureliaEffect
pushed a commit
that referenced
this pull request
May 21, 2023
**BREAKING CHANGE:** * **compiler:** avoid using au class to find targets (#1768) ([0d30998](0d30998)). * ***:** rename resolveAll -> onResolveAll (#1764) ([fdf0747](fdf0747)) **Features:** * **di:** ability to use newInstance()/forScope() with interface (#1767) ([a0d39e9](a0d39e9)) * **all:** allow injection of implementation (#1766) ([a60db13](a60db13)) * **templating:** allow deactivate when activating (#1729) ([1c9c97c](1c9c97c)) * **bindable:** support getter/setter (#1753) ([4279851](4279851)) * **ui-virtualization:** enhance implementation & publish package (#1759) ([7a2f17f](7a2f17f)). Thanks [@Lakerfield](https://github.com/Lakerfield) **Refactorings:** * ***:** cleanup up unused code & decouple interface from default impl (#1761) ([7a71d43](7a71d43)) * **router:** add warning for unsupported behavior (#1757) ([ce87339](ce87339)). The router used to allow container traversal to find resources when a string is used as a route to find the corresponding component. Going forward this will be invalid and resources must be registered either locally or globally to be routable. A warning is added first so app that accidentally used this behavior can detect the invalid usages and fix accordingly first. This behavior will be removed in a near future release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π Description
This PR makes it possible to call deactivate on a controller while it's activating. The controller will complete the activation step it's on and then deactivate through the steps it had done so far while activating.
π Test Plan
β Next Steps