refactor(router): add warning for unsupported behavior #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AureliaEffect
pushed a commit
that referenced
this pull request
May 21, 2023
**BREAKING CHANGE:** * **compiler:** avoid using au class to find targets (#1768) ([0d30998](0d30998)). * ***:** rename resolveAll -> onResolveAll (#1764) ([fdf0747](fdf0747)) **Features:** * **di:** ability to use newInstance()/forScope() with interface (#1767) ([a0d39e9](a0d39e9)) * **all:** allow injection of implementation (#1766) ([a60db13](a60db13)) * **templating:** allow deactivate when activating (#1729) ([1c9c97c](1c9c97c)) * **bindable:** support getter/setter (#1753) ([4279851](4279851)) * **ui-virtualization:** enhance implementation & publish package (#1759) ([7a2f17f](7a2f17f)). Thanks [@Lakerfield](https://github.com/Lakerfield) **Refactorings:** * ***:** cleanup up unused code & decouple interface from default impl (#1761) ([7a71d43](7a71d43)) * **router:** add warning for unsupported behavior (#1757) ([ce87339](ce87339)). The router used to allow container traversal to find resources when a string is used as a route to find the corresponding component. Going forward this will be invalid and resources must be registered either locally or globally to be routable. A warning is added first so app that accidentally used this behavior can detect the invalid usages and fix accordingly first. This behavior will be removed in a near future release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摉 Description
At the moment, the router is doing a container traversal to get a component instance, when a component name is used in an instruction. This is not an intended behavior, and should be removed.
Adding a warning so that apps can have some time to check/avoid this issue. It'll be removed in a near future release.
cc @jwx