feat(bindable): support getter/setter #1753
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摉 Description
resolves #1602
Currently, bindable can only be used with a field, which means the following usages are invalid:
An attribute with a readonly bindable
And more similar logics, where a pair of setter/getter are more desirable than a field.
This PR refactors the bindable infra, as well as adds support for the above usage. It does so by treating bindable just as bindable metada for compilation, and enhance existing observers with capabilities to perform work of the bindable observation.
With this work in place, supporting the new decorator proposal will be much easier since we are capable of handle getter/setter from the new auto accessor feature.
馃搼 Test Plan
cc @brandonseydel