feat(compose): passthrough bindings + support containerless #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1792 +/- ##
==========================================
+ Coverage 88.43% 88.45% +0.02%
==========================================
Files 245 247 +2
Lines 22335 22360 +25
Branches 5191 5199 +8
==========================================
+ Hits 19751 19778 +27
+ Misses 2584 2582 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bigopon
changed the title
bigopon
changed the title
Vheissu
reviewed
Jul 10, 2023
Co-authored-by: Dwayne Charrington <dwaynecharrington@gmail.com>
AureliaEffect
pushed a commit
that referenced
this pull request
Jul 24, 2023
**Features:** * **compose:** passthrough bindings + support containerless (#1792) ([e8e39a9](e8e39a9)) * **template:** access global (#1790) ([2486b58](2486b58)) **Bug Fixes:** * **router-lite:** handling slash in parameter value (#1805) ([3fbb698](3fbb698)) * **au-slot:** correctly prepare resources for slotted view (#1802) ([bf1ca4c](bf1ca4c)) * **router-lite:** e2e build ([a1ca36d](a1ca36d)) **Refactorings:** * **ref:** deprecate view-model.ref and introduce component.ref (#1803) ([97e8dad](97e8dad)) * **text-binding:** always evaluate expressions in strict mode (#1801) ([15acfee](15acfee)) * **router-lite:** query in fragment when using useUrlFragmentHash option (#1794) ([a1ca36d](a1ca36d)) * ***:** bindable property -> name (#1783) ([ca0eda7](ca0eda7)) * **router-lite:** optimize object creation (#1782) ([c1ef0a3](c1ef0a3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
At the moment,
<au-compose/>does not "pass through" bindings declared on the<au-compose>element. This creates undesirable workaround and sometimes, limitation. This is also a frequently requested feature of v1. This PR adds the ability to pass through all bindings declared on<au-compose/>to the composed custom element, so that it is as if the bindings, even bindable properties, were declared on the custom element itself.<au-compose/>will throw. Remove this constraint and containerless composition will just work as normal. This effectively make<au-compose/>as natural as a normal custom element usage, except it's more dynamic.cc @Sayan751 @fkleuver
Resolves #497