-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(router-lite): query in fragment when using useUrlFragmentHash option #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1794 +/- ##
==========================================
+ Coverage 88.45% 88.52% +0.07%
==========================================
Files 247 248 +1
Lines 22360 22352 -8
Branches 5199 5199
==========================================
+ Hits 19778 19787 +9
+ Misses 2582 2565 -17
π£ Weβre building smart automated test selection to slash your CI/CD build times. Learn more |
bigopon
approved these changes
Jul 12, 2023
AureliaEffect
pushed a commit
that referenced
this pull request
Jul 24, 2023
**Features:** * **compose:** passthrough bindings + support containerless (#1792) ([e8e39a9](e8e39a9)) * **template:** access global (#1790) ([2486b58](2486b58)) **Bug Fixes:** * **router-lite:** handling slash in parameter value (#1805) ([3fbb698](3fbb698)) * **au-slot:** correctly prepare resources for slotted view (#1802) ([bf1ca4c](bf1ca4c)) * **router-lite:** e2e build ([a1ca36d](a1ca36d)) **Refactorings:** * **ref:** deprecate view-model.ref and introduce component.ref (#1803) ([97e8dad](97e8dad)) * **text-binding:** always evaluate expressions in strict mode (#1801) ([15acfee](15acfee)) * **router-lite:** query in fragment when using useUrlFragmentHash option (#1794) ([a1ca36d](a1ca36d)) * ***:** bindable property -> name (#1783) ([ca0eda7](ca0eda7)) * **router-lite:** optimize object creation (#1782) ([c1ef0a3](c1ef0a3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π Description
This fixes the issue reported on Discourse.
Note that this is a"breaking change" if you are relying on the location API, directly. However, if you are using the routing hooks, such as
canLoad
,loading
etc., and you are using router-lite API (grabbing the query string and fragment from theRouteNode
), then you should be fine.π« Issues
π©βπ» Reviewer Notes
π Test Plan
β Next Steps
cc: @ivanbacher