refactor(text-binding): always evaluate expressions in strict mode #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1801 +/- ##
=======================================
Coverage 88.51% 88.51%
=======================================
Files 248 248
Lines 22352 22352
Branches 5199 5200 +1
=======================================
Hits 19785 19785
Misses 2567 2567
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AureliaEffect
pushed a commit
that referenced
this pull request
Jul 24, 2023
**Features:** * **compose:** passthrough bindings + support containerless (#1792) ([e8e39a9](e8e39a9)) * **template:** access global (#1790) ([2486b58](2486b58)) **Bug Fixes:** * **router-lite:** handling slash in parameter value (#1805) ([3fbb698](3fbb698)) * **au-slot:** correctly prepare resources for slotted view (#1802) ([bf1ca4c](bf1ca4c)) * **router-lite:** e2e build ([a1ca36d](a1ca36d)) **Refactorings:** * **ref:** deprecate view-model.ref and introduce component.ref (#1803) ([97e8dad](97e8dad)) * **text-binding:** always evaluate expressions in strict mode (#1801) ([15acfee](15acfee)) * **router-lite:** query in fragment when using useUrlFragmentHash option (#1794) ([a1ca36d](a1ca36d)) * ***:** bindable property -> name (#1783) ([ca0eda7](ca0eda7)) * **router-lite:** optimize object creation (#1782) ([c1ef0a3](c1ef0a3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
Currently all bindings are evaluating expressions in strict mode, and have proved to be working fine for applications migrating from v1. Text binding (content binding), however, was not using this strict by default mode as there could be some bug regards to how null/undefined are handled.
This exception creates a discrepancy that is hard to explain, also there's not a lot of benefits doing this. Remove this behavior.
This open the way for us to remove non-strict mode in expression evaluation, as optional syntaxes are already supported. Though this will be another follow up PR.
Closes #1769 #1798