-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove define hook from documentation #1903
Conversation
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## master #1903 +/- ##
==========================================
- Coverage 88.37% 88.36% -0.01%
==========================================
Files 260 260
Lines 22856 22856
Branches 5299 5299
==========================================
- Hits 20198 20196 -2
- Misses 2658 2660 +2 β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this @ivanbacher just a few C's.
docs/user-docs/getting-to-know-aurelia/routing/aurelia-router-lite/README.md
Outdated
Show resolved
Hide resolved
docs/user-docs/getting-to-know-aurelia/routing/aurelia-router/README.md
Outdated
Show resolved
Hide resolved
No problem. Ups, not sure what happened there, might have been during the GitBook import/sync. Anyway I removed the unnecessary files |
Thanks @ivanbacher , nice work! |
2.0.0-beta.12 (2024-03-02) **BREAKING CHANGE:** * **enhance:** call app tasks with `.enhance` API, return app root instead of controller (#1916) ([4d522b2](4d522b2)) * **au-compose:** always create host for non custom element composition (#1906) ([8a28e0a](8a28e0a)) **Features:** * **au-compose:** ability to compose string as element name (#1913) ([06aa113](06aa113)) **Bug Fixes:** * **router:** prevent multiple navigation at the same time (#1895) ([deed11e](deed11e)) * **router:** properly handle false in conditional router hooks (#1900) ([a671463](a671463)) * **di:** dont jit register resources ([8ffde34](8ffde34)) * **di:** new instance resolver (#1909) ([efe208c](efe208c)) * **runtime:** tweak typings of injectable token ([89f76eb](89f76eb)) **Refactorings:** * **runtime:** delay overriding array prototypes (#1914) ([d8be144](d8be144)) * **router:** use resolve ([89f76eb](89f76eb)) * **runtime:** better type inferrence for injectable token ([89f76eb](89f76eb)) * **di:** simplify container has, cleanup router ([89f76eb](89f76eb)) **Docs:** * **docs:** add JS examples using resolve for IHttpClient (#1907) ([d57c1f1](d57c1f1)) * **doc:** remove define hook from documentation (#1903) ([f684141](f684141))
Pull Request
π Description
In the latest beta release you mention this:
This pull request just removes any mention of define from the component lifecycle hook documentation
π« Issues
π©βπ» Reviewer Notes
π Test Plan
β Next Steps