-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(au-compose): always create host for non custom element composition #1906
Conversation
always create new composition host/location for non custom element
@bigopon give me a couple of days to look at it, please. Need to dive in again. |
add doc for tag binding
…ctor/au-compose-tag
doc change is here https://github.com/aurelia/aurelia/pull/1906/files#diff-8cd6af03635c2537aa4b1ff7d67527c37afa3205f4e823d8c79620fe9cfcea54R62 aurelia/docs/user-docs/getting-to-know-aurelia/dynamic-composition.md Lines 62 to 93 in 741a893
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1906 +/- ##
==========================================
+ Coverage 88.37% 88.38% +0.01%
==========================================
Files 260 260
Lines 22856 22858 +2
Branches 5299 5298 -1
==========================================
+ Hits 20198 20203 +5
+ Misses 2658 2655 -3 ☔ View full report in Codecov by Sentry. |
@ekzobrain no worries. I'll go ahead first, will accommodate any issues we discover |
2.0.0-beta.12 (2024-03-02) **BREAKING CHANGE:** * **enhance:** call app tasks with `.enhance` API, return app root instead of controller (#1916) ([4d522b2](4d522b2)) * **au-compose:** always create host for non custom element composition (#1906) ([8a28e0a](8a28e0a)) **Features:** * **au-compose:** ability to compose string as element name (#1913) ([06aa113](06aa113)) **Bug Fixes:** * **router:** prevent multiple navigation at the same time (#1895) ([deed11e](deed11e)) * **router:** properly handle false in conditional router hooks (#1900) ([a671463](a671463)) * **di:** dont jit register resources ([8ffde34](8ffde34)) * **di:** new instance resolver (#1909) ([efe208c](efe208c)) * **runtime:** tweak typings of injectable token ([89f76eb](89f76eb)) **Refactorings:** * **runtime:** delay overriding array prototypes (#1914) ([d8be144](d8be144)) * **router:** use resolve ([89f76eb](89f76eb)) * **runtime:** better type inferrence for injectable token ([89f76eb](89f76eb)) * **di:** simplify container has, cleanup router ([89f76eb](89f76eb)) **Docs:** * **docs:** add JS examples using resolve for IHttpClient (#1907) ([d57c1f1](d57c1f1)) * **doc:** remove define hook from documentation (#1903) ([f684141](f684141))
📖 Description
Currently the
<au-compose/>
composition tries to be smart when composing non-custom element:<au-compose/>
usage is notcontainerless
(via<au-compose containerless/>
usage): it'll use its own host element (<au-compose/>
element) as the host for the composition<au-compose/>
usage is a containerless: it'll use its comment markers as the comment markers for the compositionThis has a few issues:
This PR refactors the
<au-compose/>
composing behavior:<au-compose/>
itself will always be containerless<au-compose/>
related own html):Usage:
tag
binding on the<au-compose>
element.tag
is a new bindable property of the<au-compose>
element and is used to specify what element to create in the non custom element composition. For the above example, we can do:<au-compose/>
usage will also be transferred to this host element, which means we can do