Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading without System does not work #13

Closed
jods4 opened this issue Jul 1, 2015 · 3 comments
Closed

Loading without System does not work #13

jods4 opened this issue Jul 1, 2015 · 3 comments
Labels

Comments

@jods4
Copy link
Contributor

jods4 commented Jul 1, 2015

#9 was fixed quickly but not tested because the fix is not sufficient.

The problem is now that aurelia-metadata gets loaded first and it creates a very rudimentary System polyfill: basically just forEachModule.

When aurelia-bootstrapper loads, it sees window.System and tries to use it, which fails miserably.

The check that doesn't work:
https://github.com/aurelia/bootstrapper/blob/master/src/index.js#L54

Why it fails:
https://github.com/aurelia/metadata/blob/master/src/metadata.js#L20

@EisenbergEffect
Copy link
Contributor

I think we have this fixed now.

@jods4
Copy link
Contributor Author

jods4 commented Jul 1, 2015

I tried with the latest aurelia-metadata but it did not work. The rest of the packages were still based on aurelia-bootstrapper: ~0.13.1 though.

I have a project set up with requirejs, so let me know if you want me to test this.

@EisenbergEffect
Copy link
Contributor

It's not released yet. Look for it later today or tomorrow morning. There will be a blog post to accompany the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants