Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron no longer functions due to Issue #26 being fixed. #27

Closed
MiiCode2 opened this issue Jan 14, 2016 · 2 comments
Closed

Electron no longer functions due to Issue #26 being fixed. #27

MiiCode2 opened this issue Jan 14, 2016 · 2 comments
Assignees

Comments

@MiiCode2
Copy link

The fix done in #26 has stopped Electron from launching any applications.

By reversing window.system and window.require checks in function createLoader(), Electron will start functioning again.

See the erroneous code here:

if (window.require) {
return new Promise(function (resolve, reject) {
return require(['aurelia-loader-default'], function (m) {
return resolve(new m.DefaultLoader());
}, reject);
});
} else if (window.System) {
return System.normalize('aurelia-bootstrapper').then(function (bootstrapperName) {
return System.normalize('aurelia-loader-default', bootstrapperName);
}).then(function (loaderName) {
return System['import'](loaderName).then(function (m) {
return new m.DefaultLoader();
});
});
}

@EisenbergEffect EisenbergEffect self-assigned this Jan 14, 2016
@EisenbergEffect
Copy link
Contributor

It fixed another bug. So, we are going to have to rethink this because if we switch it back it will break other scenarios. I think core-js now defines system and confuses it if we switch. Need to think about it...

@EisenbergEffect
Copy link
Contributor

Ok, this is fixed in master. We'll get it out in the next day or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants