Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CLI-Bundler, Aliases): improve alias support #1094

Merged

Conversation

michaelw85
Copy link
Contributor

Define multiple aliases when they can be applied for a path.

Closes #1093

Define multiple aliases when they can be applied for a path.

Closes aurelia#1093
@michaelw85
Copy link
Contributor Author

@huochunpeng Here you go. I moved the function into a separate file and changed it to return multiple matches.

@3cp
Copy link
Member

3cp commented Apr 26, 2019

Awesome, LGTM.

@michaelw85
Copy link
Contributor Author

@EisenbergEffect Is it possible to get this merged?

@EisenbergEffect EisenbergEffect merged commit adf8742 into aurelia:master Apr 26, 2019
@EisenbergEffect
Copy link
Contributor

Yes sir! Thanks for the contribution!

@michaelw85 michaelw85 deleted the 1093_support_multiple_aliases branch April 27, 2019 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI Bundler alias/paths matched incorrectly (Plugin development)
3 participants