Fixed broken au run command for Windows
#1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3cp
requested changes
Apr 23, 2024
|
The doc "Create a new project with au new" doesn't mean to create new project within your cli repo folder. I think that's where it confused you. |
3cp
approved these changes
Apr 24, 2024
|
I will fix the CI setup after. |
|
Seems like nodejs 20 is not happy with aurelia-cli. I will fix those regressions before next release. |
|
It was mock-fs (only for unit tests) doesn't work with nodejs 20. I need to remove it. |
|
v3.0.3 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest node.js update, Windows machine will fail to run
au runcommand. More details in the following issue: #1205. This PR adds ashell: trueoption to the parameters of thespawn()method (only for Windows machine) as suggested by node.js.Additionally, I updated the machine set up guide in the readme document. It appears that a building step no longer exists within the
package.json.NOTE: This code change has been tested in macOS Sonoma and Windows 11.