New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundler): don't trace dependencies which have no main file #673

Merged
merged 1 commit into from Aug 14, 2017

Conversation

Projects
None yet
2 participants
@JeroenVinke
Member

JeroenVinke commented Jul 3, 2017

closes #435 (comment)

I need to do some final tests and rebase it on master

@JeroenVinke

This comment has been minimized.

Show comment
Hide comment
@JeroenVinke

JeroenVinke Jul 3, 2017

Member

#435 (comment) is a better solution. I'll update this PR

Member

JeroenVinke commented Jul 3, 2017

#435 (comment) is a better solution. I'll update this PR

@zewa666

This comment has been minimized.

Show comment
Hide comment
@zewa666

zewa666 Aug 12, 2017

Member

Wow, that fix, so simple yet so effective.

Fresh TS scaffold with:

{
  "name": "rxjs",
  "path": "../node_modules/rxjs",
  "main": "Rx"
}

648kb vendor file

and with main: false 410kb.

of course its just a demo using only minimal Rx dependencies, but I still expect at least 100-150kb savings on a typical RxJS project.

You better get that merged asap :)

Member

zewa666 commented Aug 12, 2017

Wow, that fix, so simple yet so effective.

Fresh TS scaffold with:

{
  "name": "rxjs",
  "path": "../node_modules/rxjs",
  "main": "Rx"
}

648kb vendor file

and with main: false 410kb.

of course its just a demo using only minimal Rx dependencies, but I still expect at least 100-150kb savings on a typical RxJS project.

You better get that merged asap :)

@JeroenVinke JeroenVinke merged commit 3a4dab9 into aurelia:master Aug 14, 2017

1 check passed

license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment