-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot read property 'canActivate' of undefined #257
Comments
Can you provide a repro? This is strange indeed. |
The Gist that is provided is using an old version of this library (aurelia-dialog@0.5.7). Is there an updated version?
No, the OP in #135 was using webpack. |
There isn't an updated gist - sorry.
If the following is what you meant, it should work. import {UserInfoDialog} from './dialog/user';
// ...
this.dialogService.open({viewModel: UserInfoDialog}) // ...
// ... I'm adding this to my TODO list for the next release. |
@glen-84 When passing a relative path it must be relative to the app root, in SystemJS the |
Tracked in aurelia/loader-default#40 |
This is still not working. I get |
@glen-84 do you reproduce it with the previous repro you provided? |
I just updated the repro (locally), and it's now working. I guess there is some other issue with my app. |
I'm submitting a bug report
1.0.0-beta.3.0.1
Please tell us about your environment:
Operating System:
Windows 10
Node Version:
6.10.0
NPM Version:
3.10.10
JSPM OR Webpack AND Version
jspm 0.17.0-beta.40
Browser:
all
Language:
TypeScript 2.2.0
Current behavior:
When calling DialogService.open, it is no longer possible to set the viewModel to a type. A relative path doesn't work either. Only an absolute path does.
Expected/desired behavior:
It should be possible to either reference an imported type, or to use a relative path.
What is the motivation / use case for changing the behavior?
This is/was a BC break. Using an absolute path is far from ideal.
I am aware of #135, but this is not a webpack issue.
The text was updated successfully, but these errors were encountered: