Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] attach focus should accept an empty string #329

Open
bigopon opened this issue Oct 23, 2017 · 4 comments
Open

[proposal] attach focus should accept an empty string #329

bigopon opened this issue Oct 23, 2017 · 4 comments

Comments

@bigopon
Copy link
Member

bigopon commented Oct 23, 2017

if (this.value && this.value !== 'false') {

The above line should be

if (this.value === '' || this.value && this.value !== 'false') {

I think we should make attach-focus boolean attribute for the following usage

<input attach-focus />
@bigopon
Copy link
Member Author

bigopon commented Nov 5, 2017

This could be a breaking change, can we discuss it before official release @StrahilKazlachev @EisenbergEffect

@StrahilKazlachev
Copy link
Contributor

@bigopon can you give a scenario where it will be a breaking change?

@bigopon
Copy link
Member Author

bigopon commented Nov 6, 2017

When someone bind to a string, that may have value equals ''

  <input attach-focus.bind='message' />

Currently, It doesn't focus if message is ''

@Alexander-Taran
Copy link
Contributor

@bigopon do something about it (-:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants