Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest aurelia-metadata library causes decorators to fail in aurelia-validation #30

Closed
meash-nrel opened this issue Feb 11, 2016 · 4 comments

Comments

@meash-nrel
Copy link

aurelia-validation 0.6.2 unit tests are passing (once missing dependent libs are installed) when using aurelia-metadata 1.1.3.

updating aurelia-metadata to 1.1.4 causes the library's ensure decorator to stop working altogether. see aurelia/validation#216

$jspm install aurelia-metadata
... Installed aurelia-metadata as npm:aurelia-metadata@^1.0.0-beta.1.1.4 (1.0.0-beta.1.1.4)
... aurelia-metadata 1.0.0-beta.1.1.3 -> 1.0.0-beta.1.1.4

Unit tests in aurelia-validation will now fail - as the ensure decorator no longer functions.

Not seeing any commits in this package of note from 1.1.3 to 1.1.4. What could be causing this inter-dependency failure?

@meash-nrel
Copy link
Author

Looking at this library's dependencies, it's only aurelia-pal and core-js. Prior to updating aurelia-metadata from 1.1.3, i had already upgraded to aurelia-pal@1.0.0-beta.1.1.1, and core-js 2.1.0 in aurelia-validation. So the latest versions of the underlying dependency libs were being used prior to aurelia-metadata being updated. Everything was working.

Update aurelia-metadata, though, and then decorators stop working.

@doktordirk
Copy link
Contributor

core-js@2.0.3 might be the problem.
see (aurelia/validation#216 (comment))

@meash-nrel
Copy link
Author

it appears the issue is due to core-js change vs shim in use. closing this as it seems issue is within validation lib.

@meash-nrel
Copy link
Author

Before the core-js bump the aurelia metadata had it's own polyfills for metadata reflection, with the core-js update these were replaced by the core-js versions.

Unsure if metadata lib needs to reflect the shim diff or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants