Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify aurelia-pal version in typings dependency. #49

Closed
jp7677 opened this issue Dec 29, 2016 · 2 comments
Closed

Specify aurelia-pal version in typings dependency. #49

jp7677 opened this issue Dec 29, 2016 · 2 comments

Comments

@jp7677
Copy link

jp7677 commented Dec 29, 2016

Hi there,

When installing the TypeScript typings for a project that uses aurelia-metadata with typings install you will see the following output:

typings WARN badlocation "github:aurelia/pal" is mutable and may change, consider specifying a commit hash
├─┬ aurelia-metadata
│ └── aurelia-pal

This happens because https://github.com/aurelia/metadata/blob/master/typings.json does not specifies a version. Wouldn't it be better if the aurelia-pal dependency was specified as e.g.
"aurelia-pal": "github:aurelia/pal#1.0.0"
instead of just
"aurelia-pal": "github:aurelia/pal".
That would resolve the imho justified warning.

PS: The same applies to https://github.com/aurelia/pal-browser/blob/master/typings.json.

@loku02
Copy link

loku02 commented May 15, 2017

Any progress here? This doesn't change for almost a year now.

@jp7677
Copy link
Author

jp7677 commented Nov 19, 2017

I had moved from jspm/typings to webpack some time ago. Closing this since this is no longer an issue for me.

@jp7677 jp7677 closed this as completed Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants