Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'window.webkitStorageInfo' is deprecated. Please use 'navigator.webkitTemporaryStorage' or 'navigator.webkitPersistentStorage' instead #56

Closed
michaelbull opened this issue Mar 21, 2018 · 11 comments · Fixed by #65

Comments

@michaelbull
Copy link

I'm submitting a bug report

  • Library Version:
    1.0.3

Please tell us about your environment:

  • Operating System:
    Linux F27

  • Node Version:
    8.9.4

  • NPM Version:
    5.6.0
  • JSPM OR Webpack AND Version
    webpack 4
  • Browser:
    Chrome Version 65.0.3325.146 (Official Build) (64-bit)

  • Language:
    TypeScript 2.7.2

Current behavior:

I just started using viewports in a few of my routing behaviours. The Chrome devtools console is giving me this warning:

aurelia-metadata.js?c04d:64 [Deprecation] 'window.webkitStorageInfo' is deprecated. Please use 'navigator.webkitTemporaryStorage' or 'navigator.webkitPersistentStorage' instead.
(anonymous) @ aurelia-metadata.js?c04d:64
(anonymous) @ aurelia-loader-webpack.js?b873:144
WebpackLoader.__WEBPACK_IMPORTED_MODULE_2_aurelia_pal__.PLATFORM.eachModule @ aurelia-loader-webpack.js?b873:141
get @ aurelia-metadata.js?c04d:61
getViewStrategy @ aurelia-templating.js?f83c:690
process @ router-view.js?e967:113
_loop @ aurelia-router.js?ec12:291
_commitChanges @ aurelia-router.js?ec12:305
(anonymous) @ aurelia-router.js?ec12:293
Promise.then (async)
_loop @ aurelia-router.js?ec12:291
_commitChanges @ aurelia-router.js?ec12:305
(anonymous) @ aurelia-router.js?ec12:293
Promise.then (async)
_loop @ aurelia-router.js?ec12:291
_commitChanges @ aurelia-router.js?ec12:305
run @ aurelia-router.js?ec12:143
next @ aurelia-router.js?ec12:112
iterate @ aurelia-router.js?ec12:1302
inspect @ aurelia-router.js?ec12:1279
(anonymous) @ aurelia-router.js?ec12:1295

It is specifically complaining about this line

Console

Expected/desired behavior:

  • What is the expected behavior?

The library should be updated to not use the deprecated functionality.

  • What is the motivation / use case for changing the behavior?

Remove console deprecation warnings

@Alexander-Taran
Copy link

Would you like to provide a pull request for this one @michaelbull ?
something like let storageInfo = navigator.webkitTemporaryStorage || window.webkitStorageInfo

@michaelbull
Copy link
Author

Not sure where it's being used

@avrahamcool
Copy link

avrahamcool commented May 21, 2018

when ./node_modules/webpack/buildin/global.js is loaded, the value is window.
iterating over the window properties causes this issue (because the deprecated property is still there).

image

this can be fixed like shown here.

but it's actually pointless, because when it will be actually removed - then it will not show up in the for.. in and problem solved.

@EisenbergEffect
Copy link
Contributor

Closing this since there's a workaround. Also, we'll merge a PR that prevents exceptions during enumeration, shortly.

@smajl
Copy link

smajl commented Oct 29, 2018

@EisenbergEffect Hi, any updates on the official patch? Was that aforementioned PR even created?

@EisenbergEffect
Copy link
Contributor

@smajl The patch was merged, yes.

@LilSebastian5000
Copy link

LilSebastian5000 commented Jan 7, 2019

So this is still being worked on and we should ignore the warning? Still getting this error from aurelia-metadata (webpack 3.10, ecmascript 6)

@EisenbergEffect

@abowen
Copy link

abowen commented Dec 12, 2019

I've installed version 1.0.6 and still getting this warning.

@GustavRoder
Copy link

Yup, the problem is still here with version 1.0.6 :)

@bigopon
Copy link
Member

bigopon commented May 9, 2020

Let me have a go at fixing this annoying warning then. Thanks for nudging

@josundt
Copy link
Contributor

josundt commented Oct 11, 2020

@bigopon I added PR #65 with a quick fix to this warning that has been a console distraction for some time now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants