-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: Bluebird promises, rejecting with non-error objects, "Warning: a promise was rejected with a non-error" in log #329
Comments
@valichek I don't think this is something that we can honor as we use promises for flow control in this case. Further, our API is stabilizing and this would be a breaking change. @EisenbergEffect I'm tagging this with the |
Is the official recommendation from Aurelia simply to ignore these warnings? |
This warning is bugging us as well. |
I think a similar issue got fixed in the latest release of the http client - https://github.com/aurelia/http-client/releases/tag/1.3.0 Can a similar fix be added to the router? This error polluting the debug console is very annoying and masks possible real errors. |
@davismj What's the original issue this one is a duplicate of? |
Here is a reason:
https://github.com/aurelia/router/blob/master/src/navigation-plan.js#L34
Here is explanation of warning.
https://github.com/petkaantonov/bluebird/blob/master/docs/docs/warning-explanations.md#warning-a-promise-was-rejected-with-a-non-error
The text was updated successfully, but these errors were encountered: