Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(router config): ignoreUnknownRoutes option #558
Dec 11, 2017
referenced this pull request
Dec 16, 2017
@EisenbergEffect I've done some simple testing and I've found that this doesn't seem to solve the issue it was trying to address. In any case, I think we shouldn't release this until its tested and verified, and I'm looking to get a release of the latest changes out in the next week. Shall I revert this using the GitHub revert feature, or manually in Git?
In a nutshell if you have pushState enabled you should still be able to create an href that is not swallowed by the router (they all currently are) and instead you should be able to trigger navigation that the router ignores. I think the existing PR simply swallowed the error but we need to propagate the route up which the PR I linked above addresses but is probably a work in progress, let me know if that makes sense. Also if we are not releasing until Tuesday please do not revert a commit without giving the author a chance to fix the issue.