Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(precompiles): Always charge for gas in ecrecover #305

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

birchmd
Copy link
Member

@birchmd birchmd commented Oct 12, 2021

Closes #301

Thanks @rakita for reporting!

@birchmd birchmd added C-bug Category: Something isn't working. A-precompiles Area: Issues that relate to the precompiles. labels Oct 12, 2021
@birchmd birchmd linked an issue Oct 12, 2021 that may be closed by this pull request
Copy link
Contributor

@joshuajbouw joshuajbouw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix! Thanks

@birchmd birchmd merged commit b3fbeec into develop Oct 15, 2021
@birchmd birchmd deleted the 301-ecrecover-gas-cost branch October 15, 2021 12:06
artob pushed a commit that referenced this pull request Nov 1, 2021
* Feat(engine): Public method for computing block hash at given height (#303)
* Fix(precompiles): Always charge for gas in ecrecover (#305)
* Fix(precompiles): Pad modexp input if it is too short (#306)
* Feat(engine): Include address field in returned EVM logs (#299)
* Fix(engine): Remove unnecessary eth-connector logic (#312)
* Feat(benchmarks): update gas bounds after wasm cost reduction (#315)
* Fix(engine): update to latest SputnikVM (#316)
* Add logging of public of the signer (#319)

Co-authored-by: Dmitry Strokov <dmitry.strokov@aurora.dev>
Co-authored-by: Joshua J. Bouw <joshua@aurora.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-precompiles Area: Issues that relate to the precompiles. C-bug Category: Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precompile eRecovery, gas consumption.
2 participants