Feat(engine): Include address field in returned EVM logs #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
added
C-enhancement
Closed
joshuajbouw
approved these changes
Oct 9, 2021
|
After aurora-is-near/aurora.js#22 is merged (and anything that depends on |
|
Noted. |
|
@joshuajbouw Is there anything preventing us from merging this PR and releasing it ? |
Of course, API breaking. Everything that depend on the engine requires updating first. |
birchmd
added a commit
that referenced
this pull request
Oct 15, 2021
birchmd
force-pushed
the
286-address-in-logs
branch
from
ee43976
to
6ddab87
Compare
|
aurora-is-near/aurora.js#22 has now been merged and deployed to all endpoints, so this is good to go (modulo adequate validation). |
|
Great we'll get this in. @birchmd |
birchmd
force-pushed
the
286-address-in-logs
branch
from
6ddab87
to
45c8edd
Compare
artob
pushed a commit
that referenced
this pull request
Nov 1, 2021
* Feat(engine): Public method for computing block hash at given height (#303) * Fix(precompiles): Always charge for gas in ecrecover (#305) * Fix(precompiles): Pad modexp input if it is too short (#306) * Feat(engine): Include address field in returned EVM logs (#299) * Fix(engine): Remove unnecessary eth-connector logic (#312) * Feat(benchmarks): update gas bounds after wasm cost reduction (#315) * Fix(engine): update to latest SputnikVM (#316) * Add logging of public of the signer (#319) Co-authored-by: Dmitry Strokov <dmitry.strokov@aurora.dev> Co-authored-by: Joshua J. Bouw <joshua@aurora.dev>
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to adding the address field to the returned EVM logs, this PR also introduces a version byte to the
SubmitResultABI. This byte can be used to discriminate the new ABI from the old, and in the future can discriminate future breaking ABI changes from each other.closes #286