Feat(benchmarks): update gas bounds after wasm cost reduction #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birchmd
added
C-enhancement
3 tasks
birchmd
added a commit
that referenced
this pull request
Oct 20, 2021
birchmd
force-pushed
the
310-update-benchmarks
branch
from
41949c9
to
234b6e4
Compare
joshuajbouw
approved these changes
Oct 21, 2021
birchmd
force-pushed
the
310-update-benchmarks
branch
from
234b6e4
to
74bdf4f
Compare
birchmd
added a commit
that referenced
this pull request
Oct 26, 2021
Merged
artob
pushed a commit
that referenced
this pull request
Nov 1, 2021
* Feat(engine): Public method for computing block hash at given height (#303) * Fix(precompiles): Always charge for gas in ecrecover (#305) * Fix(precompiles): Pad modexp input if it is too short (#306) * Feat(engine): Include address field in returned EVM logs (#299) * Fix(engine): Remove unnecessary eth-connector logic (#312) * Feat(benchmarks): update gas bounds after wasm cost reduction (#315) * Fix(engine): update to latest SputnikVM (#316) * Add logging of public of the signer (#319) Co-authored-by: Dmitry Strokov <dmitry.strokov@aurora.dev> Co-authored-by: Joshua J. Bouw <joshua@aurora.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #310
After lowering the wasm gas cost (see near/nearcore#4979), we see about a 35%-40% decrease (i.e.
new_gas = old_gas * (1 - 0.35)) in our NEAR gas usage (based on the various regression tests we have. This should correspond to around a 1.5x increase in the EVM gas limit we can support. E.g. if we could handle around 600k EVM gas previously, now we should be able to handle around 900k.Note: this PR is only updating our tests. The gas cost reduction on the live NEAR mainnet is expected to occur on November 15.