Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

Get num_confirmations from the EthClient #87

Open
alexauroradev opened this issue Feb 9, 2021 · 2 comments
Open

Get num_confirmations from the EthClient #87

alexauroradev opened this issue Feb 9, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers P2

Comments

@alexauroradev
Copy link

At the moment we use hardcoded number of the confirmations required by the client contract.

This should be updated with the. view method of the same contract, once it's implemented. Corresponding client issue is here
@alexauroradev alexauroradev added enhancement New feature or request good first issue Good for newcomers P2 labels Feb 9, 2021
@chadoh
Copy link
Contributor

chadoh commented Feb 10, 2021

This should be part of a connector, not the client. Correct? Different kinds of connectors may have different security needs. Client could set a floor, maybe.

@alexauroradev
Copy link
Author

In general, agree.
But at the moment, this is a part of the client. There's the other issue for moving it to the connector level: Near-One/rainbow-bridge#388

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chadoh @alexauroradev