Custom plugins documentation #130
Conversation
Awesome! I'll make sure they get added 😃 |
| OfferSet | ||
| -------- | ||
| OfferSet holds all offers for the scheduler. OfferSet is customizable via Interface `org.apache.aurora.scheduler.offers.OfferSet`. | ||
| This interface is injectable via the '-offer_set_module' flag. |
There was a problem hiding this comment.
The purpose of "OfferSet" as a plugin is a bit elusive here. Could you add a few sentences about its purpose and how it relates with other offer related parameters in the scheduler? (i.e. be able to have more flexibility in the filtering/ordering of the offers when offer_order is insufficient?).
Additionally given that the OfferSet interface is a bit lacking on documentation, add a few notes here about its life cycle. I.e. when add(), remove(), or getOrdered() are invoked by the scheduler; and how is that related with offer_filter_duration, min_offer_hold_time, etc.
There was a problem hiding this comment.
will do some research and add them. thanks @mauri
There was a problem hiding this comment.
Maybe we can borrow some words from the original proposal: https://docs.google.com/document/d/1fVHLt9AF-YbOCVCDMQmi5DATVusn-tqY8DldKbjVEm0/edit
Added
docs/features/custom-plugins.mdUpdated
docs/README.md