Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using kotlin.Unit in public APIs #414

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Stop using kotlin.Unit in public APIs #414

merged 1 commit into from
Jan 7, 2021

Conversation

lbalmaceda
Copy link
Contributor

Changes

Unit is not directly available on Java-only projects. To avoid compile issues, this PR changes the public APIs to use Void where Unit was used.

@lbalmaceda lbalmaceda added CH: Changed medium Medium review labels Jan 7, 2021
@lbalmaceda lbalmaceda added this to the v2-Next milestone Jan 7, 2021
@lbalmaceda lbalmaceda requested a review from a team as a code owner January 7, 2021 17:46
@lbalmaceda lbalmaceda changed the base branch from master to v2-dev January 7, 2021 17:46
jimmyjames
jimmyjames previously approved these changes Jan 7, 2021
@lbalmaceda lbalmaceda merged commit 7631c35 into v2-dev Jan 7, 2021
@lbalmaceda lbalmaceda deleted the mv-unit-void branch January 7, 2021 19:31
@lbalmaceda lbalmaceda modified the milestones: v2-Next, 2.0.0-beta.0 Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants