Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DXCDT-544: Add universal-login customize command #882

Merged
merged 20 commits into from
Nov 2, 2023
Merged

DXCDT-544: Add universal-login customize command #882

merged 20 commits into from
Nov 2, 2023

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Oct 17, 2023 •
edited
Loading

🔧 Changes

This PR adds the auth0 universal-login customize command that allows users to preview all branding customizations in a browser window.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023 •
edited
Loading

Codecov Report

Attention: 182 lines in your changes are missing coverage. Please review.

Comparison is base (62a21b2) 73.40% compared to head (991514d) 72.90%.
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
- Coverage   73.40%   72.90%   -0.51%     
==========================================
  Files          92       93       +1     
  Lines       11895    12337     +442     
==========================================
+ Hits         8732     8994     +262     
- Misses       2647     2822     +175     
- Partials      516      521       +5
Files Coverage Δ
internal/auth0/auth0.go 100.00% <100.00%> (ø)
internal/cli/prompts_custom_text.go 68.50% <ø> (+0.67%) ⬆️
internal/cli/universal_login.go 90.06% <100.00%> (+0.06%) ⬆️
internal/cli/universal_login_templates.go 46.47% <100.00%> (+0.37%) ⬆️
internal/cli/universal_login_customize.go 58.63% <58.63%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sergiught and others added 18 commits November 1, 2023 10:42
@sergiught
DXCDT-545: Add universal-login customize command skeleton (#860)
d15bea9
@sergiught
DXCDT-546: Add logic to fetch universal login branding data (#861)
0b561e4
@sergiught @Widcket
DXCDT-547: Add websocket connection and send data on connect (#863)
20c96a2 
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
@sergiught
DXCDT-548: Serve prompt data on demand (#868)
5dc4a9e
@sergiught @Widcket
DXCDT-564: Ensure new ul experience is active when customizing ul (#869)
fcce165 
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
@sergiught
DXCDT-549: Add logic to save branding data that gets sent by the web …
858858a 
…app (#872)
@sergiught
Remove usernameOnlyPlaceholder from default custom text translations (#…
effa673 
…873)
@sergiught
Use stable version of text locales url (#878)
d9b36fe
@sergiught
DXCDT-550: Propagate errors through websocket connection (#879)
8bea225
@sergiught
Add custom marshal and unmarshal funcs to websocket message (#880)
ccc3335
@sergiught
DXCDT-550: Add success message on auth0 ul customize cmd (#883)
403495b
@sergiught
DXCDT-569: Send branding data on websocket message request (#884)
e5b120f 
Send branding data on websocket message request
@sergiught
DXCDT-576: Prevent themeID from getting sent to the web app (#885)
d082118
@sergiught
DXCDT-572: Add ability to fetch all applications in ul customize cmd (#…
1a6f20a 
…886)
@sergiught
DXCDT-555: Include universal-login customize assets (#891)
4a570db 
* Add make command to generate universal-login preview assets

* Add universal-login preview assets

* Add route to serve universal-login customize assets

* Update assets

* Minor tweaks to web server url path

* Update assets

* Add npm install to make assets

* Remove ws_port query param

* Update assets

* Tiny improvements
@sergiught
[1/3] Expand test coverage for ul customize (#892)
a1e202c 
Expand test coverage for ul customize
@sergiught
[2/3] Exclude global client from fetch all apps in ul customize (#893)
19195db 
Exclude global client from fetch all apps in ul customize
@sergiught
[3/3] Update ul customize assets (#894)
ad1ff8c 
Update ul customize assets
@sergiught sergiught force-pushed the feature/auth0-universal-login-customize branch from 2c77d49 to ad1ff8c Compare November 1, 2023 09:42
@willvedd @sergiught
Notifications in auth0 ul template update preview (#895)
991514d 
* Adding notification in storybook

* Adding notification in CLI

* Adjust command path in helper text

---------

Co-authored-by: Will Vedder <will.vedder@okta.com>
Co-authored-by: Sergiu Ghitea <28300158+sergiught@users.noreply.github.com>
@sergiught sergiught marked this pull request as ready for review November 2, 2023 07:25
@sergiught sergiught requested a review from a team as a code owner November 2, 2023 07:25
willvedd
willvedd approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🎉

@sergiught sergiught merged commit 046bdd3 into main Nov 2, 2023
8 checks passed
@sergiught sergiught deleted the feature/auth0-universal-login-customize branch November 2, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willvedd willvedd willvedd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sergiught @codecov-commenter @willvedd