Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom marshal and unmarshal funcs to websocket message #880

Merged

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Add custom marshal and unmarshal funcs to websocket message to simplify code.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feature/auth0-universal-login-customize@64c08a4). Click here to learn what that means.

Additional details and impacted files
@@                            Coverage Diff                             @@
##             feature/auth0-universal-login-customize     #880   +/-   ##
==========================================================================
  Coverage                                           ?   72.47%           
==========================================================================
  Files                                              ?       93           
  Lines                                              ?    12288           
  Branches                                           ?        0           
==========================================================================
  Hits                                               ?     8906           
  Misses                                             ?     2865           
  Partials                                           ?      517           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from DXCDT-550-propagate-errors to feature/auth0-universal-login-customize October 17, 2023 07:19
@sergiught sergiught merged commit b86b485 into feature/auth0-universal-login-customize Oct 17, 2023
8 checks passed
@sergiught sergiught deleted the DXCDT-550-refactor branch October 17, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants