DXCDT-564: Ensure new ul experience is active when customizing ul #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Oct 6, 2023
Widcket
reviewed
Oct 6, 2023
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/auth0-universal-login-customize #869 +/- ##
==========================================================================
Coverage ? 73.00%
==========================================================================
Files ? 93
Lines ? 12194
Branches ? 0
==========================================================================
Hits ? 8902
Misses ? 2774
Partials ? 518 ☔ View full report in Codecov by Sentry. |
Widcket
approved these changes
Oct 10, 2023
willvedd
approved these changes
Oct 10, 2023
sergiught
merged commit 09b010c
into
feature/auth0-universal-login-customize
8 checks passed
sergiught
added a commit
that referenced
this pull request
Nov 1, 2023
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
For the MVP we'll only allow customizing the new universal login experience so we're adding a check to ensure that is active on the tenant.
📚 References
🔬 Testing
📝 Checklist