This repository has been archived by the owner on May 17, 2023. It is now read-only.
Fix rounded corners for button group with tooltip #1413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landitus
reviewed
Jan 11, 2019
| const groupRadiusStyles = css` | ||
| ${Button.Element}:first-child { | ||
| ${Button.Element}:first-child:not(:last-child), | ||
| ${Tooltip.Trigger}:first-child > ${Button.Element} { |
There was a problem hiding this comment.
I'm not sure about adding Tooltip specific code inside the Button Group. What about wrapping each ButtonGroup child internally, so we can reference that ButtonGroup.Item to access the Button and apply the correct border-radius? This would be more robust and keep components independent.
wdyt?
|
Fixed in #1371 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a big in master, fixed it on top of #1371