Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wrap errors using
%w
instead of%v
. This allows handling errors based on the internal errors witherrors.Is
anderrors.As
, as explained here. This feature has been introduced in Go 1.13 and is back-compatible and as this repo already uses Go 1.14 it should not introduce breaking changes.This allows returning different error types in the
ValidationKeyGetter
function and then use them in the error returned byCheckJWT
. For example:References
Testing
No tests have been added because:
There doesn't currently seem to be tests testing this low-level type of thing at the moment.
It's non-breaking change that doesn't change the behaviour, unless
errors.Is
orerrors.As
are used.This change adds test coverage for new/changed/fixed functionality
Checklist
master