BucketImpl is not public

[jmferland]

BucketImpl is not public so I cannot use rate limiting without using JwkProviderBuilder. (Also I cannot set a connect and read timeout with JwkProviderBuilder, otherwise I would have just used it).

e.g. this is impossible:

JwkProvider url = new UrlJwkProvider("https://samples.auth0.com/");
Bucket bucket = new Bucket(10, 1, TimeUnit.MINUTES);
JwkProvider provider = new RateLimitJwkProvider(url, bucket);

[lbalmaceda]

That's right. You need to use the builder class. To achieve the snippet that you posted above you would do this:

JwkProvider provider = new JwkProviderBuilder("https://samples.auth0.com/")
   .rateLimited(10, 1, TimeUnit.MINUTES)
   .build();

But if you want to specify a connect/read timeout (I think you forgot to demonstrate that on the snippet) you can't do it today. I'd add a method to the builder rather than changing the visibility of the bucket implementation. I'll leave this open to track it.

[jmferland]

Even better. Sounds great, thank you!

[onelapahead]

So I wrote a simple JwkProvider for fetching our JWKS since the our OIDC provider's JWKS endpoint is not /.well-known/jwks.json. Since the builder does not have a constructor which takes in a JwkProvider, I was going to add the RateLimitJwkProvider and GuavaCachedJwkProvider manually like the README demonstrates.

Since that is not possible, I'll try to extend the JwkProviderBuilder class and override the build method to get around this but this is very annoying! Can the BucketImpl either be exposed, or should I request in a separate issue a new constructor be added to the builder?

[apgv]

@brix4dayz: You can do to this with UrlJwkProvider. Code copied from README:

JwkProvider provider = new UrlJwkProvider(new URL("https://samples.auth0.com/"));

[onelapahead]

Unfortunately not, the UrlJwkProvider only looks for JWKS at /.well-known/jwks.json (which I think should customizable as well). We're not using Auth0 as our OIDC provider but we thought your lib's were the nicest to use.

As a result, it was easier to write a custom JwkProvider that used our Feign client to retrieve the JWKS. I opened this PR to get the conversation around adding custom provider support to the builder started: #47

[apgv]

That's not completely correct. Notice the new URL() passed as parameter to UrlJwkProvider. I have used this for the same reason as you with Keycloak as a provider which has a different URL to the jwks. As the README states : "Also it can load jwks.json file from any given Url (even to a local file in your filesystem)."

[onelapahead]

Perfect! Thanks, that makes a lot more sense.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️