Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for private claims in the payload #555

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

MitMaro
Copy link
Contributor

@MitMaro MitMaro commented Dec 2, 2018

Another PR for #492

This change adds tests for private claims added to the payload during sign and ensures that after verifying the payload contains the expected claim. There are not currently any dedicated tests to private claims, so these test cases are new.

Coverage Master

=============================== Coverage summary ===============================
Statements   : 96.72% ( 236/244 )
Branches     : 97.21% ( 209/215 )
Functions    : 100% ( 23/23 )
Lines        : 97.1% ( 234/241 )
================================================================================

Coverage Branch

=============================== Coverage summary ===============================
Statements   : 96.72% ( 236/244 )
Branches     : 97.21% ( 209/215 )
Functions    : 100% ( 23/23 )
Lines        : 97.1% ( 234/241 )
================================================================================

This change adds tests for private claims added to the payload during
sign and ensures that after verifying the payload contains the expected
claim.
@MitMaro
Copy link
Contributor Author

MitMaro commented Dec 3, 2018

This is in part just testing that JSON.stringify works as expected, so I don't know how much value that these tests add. The only thing I can think of is that It does ensure that these inputs remain stable in new releases.

@ziluvatar ziluvatar merged commit 5147852 into auth0:master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants